Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows-agent): Remove all writes to registry, and remove virtualization exception #374

Merged
merged 16 commits into from
Nov 20, 2023

Conversation

EduardGomezEscandell
Copy link
Contributor

@EduardGomezEscandell EduardGomezEscandell commented Oct 30, 2023

With the recent changes in #369, we no longer need to write to the registry.

There is one behavior change here: setting the registry as read-only no longer has any effect on the program. Until now, it was an implicit message from the administrator to UP4W to block attempts to modify the config.


UDENG-1696

@EduardGomezEscandell EduardGomezEscandell self-assigned this Oct 30, 2023
@EduardGomezEscandell EduardGomezEscandell marked this pull request as draft October 30, 2023 15:31
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review November 7, 2023 12:33
@EduardGomezEscandell
Copy link
Contributor Author

After an offline discussion we settled for the Prioritize the organization option.

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I could only come up with nitpicks ;)

agentapi/go/agentapi.pb.go Outdated Show resolved Hide resolved
agentapi/go/agentapi_grpc.pb.go Show resolved Hide resolved
windows-agent/internal/proservices/ui/ui_test.go Outdated Show resolved Hide resolved
agentapi/agentapi.proto Outdated Show resolved Hide resolved
end-to-end/utils_test.go Show resolved Hide resolved
@EduardGomezEscandell EduardGomezEscandell force-pushed the dont-write-registry branch 2 times, most recently from 1f4ab5d to ae738d8 Compare November 14, 2023 13:52
@EduardGomezEscandell
Copy link
Contributor Author

EduardGomezEscandell commented Nov 14, 2023

Rebased main for the recent CI fixes. New commits start at fixup: 🌱 Improve E2E error reporting

@EduardGomezEscandell
Copy link
Contributor Author

EduardGomezEscandell commented Nov 16, 2023

CI failure fixed in #402

Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly than the other one, small change request but nothing major.

I trust your tests in the Windows part for virtual registry.

agentapi/agentapi.proto Show resolved Hide resolved
end-to-end/utils_test.go Show resolved Hide resolved
windows-agent/internal/config/config_test.go Outdated Show resolved Hide resolved
@EduardGomezEscandell
Copy link
Contributor Author

EduardGomezEscandell commented Nov 16, 2023

~~ rebase main 🕺 ~~

@EduardGomezEscandell
Copy link
Contributor Author

EduardGomezEscandell commented Nov 16, 2023

I trust your tests in the Windows part for virtual registry.

90% coverage 😎

Also I tested it manually

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once didrocks comments are addressed and acknowledged.
+1 for the code shrink and the privilege drop!

Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for addressing those comments!

Also, the OpenKey function now does not take an access argument. We only
ever need read access
This is the standard we've agreed on in the team
This is no longer relevant, as we never write to the registry.
We no longer need this, as we don't write to registry; we only read.
This field no longer exists
This field no longer exists. The test checking this field
was also removed.
Now that the write permissions to the registry are irrelevant, we
need a way for the sysadmin to enforce its configuration on the machine.
To achieve this, we set the org-provided Landscape and Pro settings
as the top layer.
@EduardGomezEscandell
Copy link
Contributor Author

Rebased main after #404 now that the CI errors should be fixed.

@EduardGomezEscandell EduardGomezEscandell merged commit 972ad3e into main Nov 20, 2023
32 checks passed
@EduardGomezEscandell EduardGomezEscandell deleted the dont-write-registry branch November 20, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants